output.js ➔ ... ➔ ??? - Code Metrics - Inspection of "Clean up" - hal2dy/html-scan - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0a8095...60f354 )

by hung

created 2018-03-25 13:19 UTC

output.js ➔ ... ➔ ??? A

↳ Parent: output.js ➔ ???

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
c	2
b	0
f	0
nc	2
dl	0
loc	8
rs	9.4285
nop	1

const fs = require('fs')
const { join } = require('path')
const { Writable } = require('stream')

module.exports = (output, data) => {
  if (!data) {
    return null
  }
  if (!output) {
    console.log(data)

  } else if (typeof output === 'string') {
    const path = join(__dirname, '../', output)
    fs.open(path, fs.W_OK, err => {
      if (err) {
        console.error(`Cannot write file to ${path}`)
        return
      }
      // TODO: maybe use appendFile for readStream
      fs.writeFileSync(path, data)
    })

  } else if (output instanceof Writable) {
    output.write(data + '\r\n')
    output.on('error', err => {
      console.error(err)
    })

  } else {
    console.error('Invalid Output')

  }
}


1			const fs = require('fs')
2			const { join } = require('path')
3			const { Writable } = require('stream')
4
5			module.exports = (output, data) => {
6			if (!data) {
7			return null
8			}
9			if (!output) {
10			console.log(data)
			0 ignored issues – show Best Practice introduced 2018-03-25 13:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history... Debugging Code introduced 2018-03-25 13:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
11			} else if (typeof output === 'string') {
12			const path = join(__dirname, '../', output)
13			fs.open(path, fs.W_OK, err => {
14			if (err) {
15			console.error(`Cannot write file to ${path}`)
16			return
17			}
18			// TODO: maybe use appendFile for readStream
19			fs.writeFileSync(path, data)
20			})
			0 ignored issues – show Best Practice introduced 2018-03-25 13:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
21			} else if (output instanceof Writable) {
22			output.write(data + '\r\n')
23			output.on('error', err => {
24			console.error(err)
25			})
			0 ignored issues – show Best Practice introduced 2018-03-25 13:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
26			} else {
27			console.error('Invalid Output')
			0 ignored issues – show Best Practice introduced 2018-03-25 13:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
28			}
29			}
30

hal2dy / html-scan

Push — master ( 0a8095...60f354 )

output.js ➔ ... ➔ ??? A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like